Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-14756: Refactor ColorPicker to use TabGroup instead of TabLayout #1801

Merged
merged 14 commits into from
Jan 17, 2025

Conversation

adrian-cocoara-lgp
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Replaced TabLayout with TabGroup to render ColorPicker's tabs

Resolution

Additional Considerations

Added CSS variables and updated ui-tests to work with the new structure

Links

WRR-14756

Comments

Enact-DCO-1.0-Signed-off-by: Adrian Cocoara adrian.cocoara@lgepartner.com

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.14%. Comparing base (b2f9904) to head (725babe).
Report is 1 commits behind head on feature/ColorPickerPOC.

Files with missing lines Patch % Lines
ColorPicker/ColorPicker.js 75.00% 3 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/ColorPickerPOC    #1801      +/-   ##
==========================================================
- Coverage                   81.14%   81.14%   -0.01%     
==========================================================
  Files                         154      154              
  Lines                        7118     7127       +9     
  Branches                     2095     2099       +4     
==========================================================
+ Hits                         5776     5783       +7     
- Misses                       1023     1025       +2     
  Partials                      319      319              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stanca-pop-lgp
Copy link
Contributor

Please also create variables for colors.

Copy link
Contributor

@stanca-pop-lgp stanca-pop-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanca-pop-lgp stanca-pop-lgp merged commit a48d876 into feature/ColorPickerPOC Jan 17, 2025
3 of 5 checks passed
@stanca-pop-lgp stanca-pop-lgp deleted the feature/WRR-14756-refactor-adi branch January 17, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants