-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRR-14756: Refactor ColorPicker to use TabGroup
instead of TabLayout
#1801
WRR-14756: Refactor ColorPicker to use TabGroup
instead of TabLayout
#1801
Conversation
…andstone into feature/WRR-14756-refactor-adi
… into feature/WRR-14756-refactor-adi
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/ColorPickerPOC #1801 +/- ##
==========================================================
- Coverage 81.14% 81.14% -0.01%
==========================================================
Files 154 154
Lines 7118 7127 +9
Branches 2095 2099 +4
==========================================================
+ Hits 5776 5783 +7
- Misses 1023 1025 +2
Partials 319 319 ☔ View full report in Codecov by Sentry. |
Please also create variables for colors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist
Issue Resolved / Feature Added
Replaced
TabLayout
withTabGroup
to render ColorPicker's tabsResolution
Additional Considerations
Added CSS variables and updated ui-tests to work with the new structure
Links
WRR-14756
Comments
Enact-DCO-1.0-Signed-off-by: Adrian Cocoara adrian.cocoara@lgepartner.com