fix: propagate features to bindeps #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haraldh
requested review from
npmccallum,
rvolosatovs and
bstrie
as code owners
github-actions
bot
added
amd sev
|
@bstrie too bad making the bindeps shims optional does not work somehow. |
Codecov Report
@@ Coverage Diff @@
## main #1788 +/- ##
===========================================
+ Coverage 43.87% 54.66% +10.78%
===========================================
Files 121 151 +30
Lines 6284 10316 +4032
===========================================
+ Hits 2757 5639 +2882
- Misses 3527 4677 +1150
Continue to review full report at Codecov.
|
|
Making bindeps optional is tracked by rust-lang/cargo#10526 . |
bstrie
reviewed
Apr 26, 2022
|
I'll test this soon. The change itself looks legit. |
jarkkojs
previously approved these changes
Apr 26, 2022
Fixup of commit 5639b58, which removed all default features. Signed-off-by: Harald Hoyer <harald@profian.com>
haraldh
force-pushed
the
propagate_features
branch
from
ff9d50a
to
b55af18
Compare
bstrie
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup of commit 5639b58, which removed
all default features.
Fixes: #1780
Signed-off-by: Harald Hoyer harald@profian.com