feat(tech): add exports option #178
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| node_modules | ||
| coverage | ||
| npm-debug.log |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| var fs = require('fs'), | ||
| path = require('path'), | ||
| mock = require('mock-fs'), | ||
| safeEval = require('node-eval'), | ||
| MockNode = require('mock-enb/lib/mock-node'), | ||
| Tech = require('../../techs/bemhtml'), | ||
| loadDirSync = require('mock-enb/utils/dir-utils').loadDirSync, | ||
|
|
@@ -205,6 +206,74 @@ describe('bemhtml', function () { | |
| }); | ||
| }); | ||
| }); | ||
|
|
||
| describe('with option `exports`', function () { | ||
|
There was a problem hiding this comment. Почему тесты не где-то в Хочется как можно меньше интеграционных тестов, если нет реальной необходимости. There was a problem hiding this comment. Кто ж знал, что тут есть разделение на интеграционные тесты ;-) There was a problem hiding this comment. @blond Я посмотрел туда. И ничо не понял. There was a problem hiding this comment. Пробую перенести в отдельный файл, разбиение по --node, --browser — мешает |
||
| it('must export ym only', function () { | ||
| var modules = {}; | ||
| return build(['block("a").tag()("a")'], { | ||
| exports: { ym: true }, | ||
| context: { | ||
| module: undefined, | ||
| modules: { | ||
| define: function (name, _, p) { | ||
| p(function (res) { modules[name] = res; }); | ||
| } | ||
| } | ||
| } | ||
| }) | ||
| .spread(function () { | ||
| modules.BEMHTML.apply({ block: 'a' }) | ||
| .must.eql('<a class="a"></a>'); | ||
| }); | ||
| }); | ||
|
|
||
| it('must export commonjs only', function () { | ||
| var m = { exports: {} }; | ||
| return build(['block("a").tag()("a")'], { | ||
| exports: { commonJS: true }, | ||
| context: { module: m } | ||
| }) | ||
| .spread(function () { | ||
| m.exports.BEMHTML.apply({ block: 'a' }) | ||
| .must.eql('<a class="a"></a>'); | ||
| }); | ||
| }); | ||
|
|
||
| it('must export global only', function () { | ||
| var window = {}; | ||
| return build(['block("a").tag()("a")'], { | ||
| exports: { globals: true }, | ||
| context: { module: undefined, window: window } | ||
| }) | ||
| .spread(function () { | ||
| window.BEMHTML.apply({ block: 'a' }) | ||
| .must.eql('<a class="a"></a>'); | ||
| }); | ||
| }); | ||
|
|
||
| it('must export as ym and global', function () { | ||
| var modules = {}, window = {}; | ||
| return build(['block("a").tag()("a")'], { | ||
| exports: { globals: 'force', ym: true }, | ||
| context: { | ||
| module: undefined, | ||
| window: window, | ||
| modules: { | ||
| define: function (name, _, p) { | ||
| p(function (res) { modules[name] = res; }); | ||
| } | ||
| } | ||
| } | ||
| }) | ||
| .spread(function () { | ||
| modules.BEMHTML.apply({ block: 'a' }) | ||
| .must.eql('<a class="a"></a>', 'modules failed'); | ||
| window.BEMHTML.apply({ block: 'a' }) | ||
| .must.eql('<a class="a"></a>', 'global failed'); | ||
| }); | ||
| }); | ||
| // return build(templates, { exports: {globals: true, commonJS: true, ym: true} }) | ||
| }); | ||
| }); | ||
|
|
||
| function build(templates, options) { | ||
|
|
@@ -215,6 +284,7 @@ function build(templates, options) { | |
| blocks: {}, | ||
| bundle: {} | ||
| }, | ||
| noEval = typeof options.context === 'object', | ||
| bundle, fileList; | ||
|
|
||
| // hack for mock-fs | ||
|
|
@@ -230,24 +300,22 @@ function build(templates, options) { | |
| scheme.blocks = templates; | ||
| } | ||
|
|
||
| mock(scheme); | ||
|
|
||
| bundle = new MockNode('bundle'); | ||
| fileList = new FileList(); | ||
| fileList.addFiles(loadDirSync('blocks')); | ||
| bundle.provideTechData('?.files', fileList); | ||
|
|
||
| return bundle[noEval ? 'runTech' : 'runTechAndRequire'](Tech, options) | ||
| .spread(function (res) { | ||
| var filename = bundle.resolvePath(bundle.unmaskTargetName(options.target || '?.bemhtml.js')), | ||
| str = fs.readFileSync(filename, 'utf-8'); | ||
|
|
||
| if (noEval) { | ||
| res = safeEval(str, filename, options.context); | ||
| } | ||
|
|
||
| return [res, str]; | ||
| }); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Давай ещё добавим описание опции
exportsвapi.ru.md.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Добавил