Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use postcss for compress #92

Merged
merged 1 commit into from
Jul 23, 2015
Merged

Use postcss for compress #92

merged 1 commit into from
Jul 23, 2015

Conversation

tavriaforever
Copy link
Contributor

Resolved #71
@blond
Not use clean-css because:

Updated:
After a detailed study and discussion, the team decided to use the lesser evil and take csswring

@tavriaforever tavriaforever self-assigned this Jul 21, 2015
@blond
Copy link
Member

blond commented Jul 21, 2015

👎 All these problems far less evil than the difference between instruments.

It has been a lot of edits for use clean-css in islands.

/сс @tadatuta @arikon

@tavriaforever
Copy link
Contributor Author

  1. Now islands compressing their css by borschik + clean-css.
  2. clean-css not compatible with sourcemap option
  3. In part of cases cssnano better compressed css

I saw only one problem, that cssnano much slower than clean-css

@tavriaforever
Copy link
Contributor Author

Send PR to bench module GoalSmashers/css-minification-benchmark#42

@arikon
Copy link
Member

arikon commented Jul 21, 2015

@blond @tavriaforever I'm not sure what to use =(

@tavriaforever
Copy link
Contributor Author

@blond update PR

it('must compressed result css', function () {
var scheme = {
blocks: {
'block.styl': 'body { ' +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему не склеить через массив? И почему тут нету переносов строк?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Переносов строк нет, согласен, лучше добавить. Что касается массива не знаю почему решил так написать, если принципиально, могу переделать с массивом.

tavriaforever added a commit that referenced this pull request Jul 23, 2015
@tavriaforever tavriaforever merged commit a4ff7fd into master Jul 23, 2015
@tavriaforever tavriaforever deleted the issue-71 branch July 23, 2015 14:44
@tavriaforever tavriaforever removed their assignment Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants