-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use postcss for compress #92
Conversation
I saw only one problem, that |
Send PR to bench module GoalSmashers/css-minification-benchmark#42 |
@blond @tavriaforever I'm not sure what to use =( |
@blond update PR |
it('must compressed result css', function () { | ||
var scheme = { | ||
blocks: { | ||
'block.styl': 'body { ' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Почему не склеить через массив? И почему тут нету переносов строк?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Переносов строк нет, согласен, лучше добавить. Что касается массива не знаю почему решил так написать, если принципиально, могу переделать с массивом.
Use postcss for compress
Resolved #71
@blond
Not use
clean-css
because:sourcemap
comment in bundle.css (can work only if building sourcemap by cleancss Don't remove source maps comments clean-css/clean-css#231)cssnano
more consistent and understandable decisionUpdated:
After a detailed study and discussion, the team decided to use the lesser evil and take csswring