This repository has been archived by the owner on Feb 25, 2022. It is now read-only.
Fix SCRIPT_NAME being included in path #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchristie
suggested changes
Aug 28, 2017
apistar/components/wsgi.py
Outdated
| @@ -34,7 +34,7 @@ def get_port(environ: WSGIEnviron): | |||
|
|
|||
|
|
|||
| def get_path(environ: WSGIEnviron): | |||
| return environ['SCRIPT_NAME'] + environ['PATH_INFO'] | |||
| return environ['PATH_INFO'] | |||
There was a problem hiding this comment.
We dont want to change this one. (!)
Will explain when at a keyboard.
tomchristie
approved these changes
Aug 29, 2017
|
Good stuff, thanks! We'll want to add |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed environ['SCRIPT_NAME'] where it was being concatenated with environ['PATH_INFO'] to get path
Fixes #257
@tomchristie I have attempted to write a test for this, but if I change the environ dict in test.py it cascades and caused all the other URL tests to fail. Not sure what the best way to handle this is as SCRIPT_NAME is only set when deployed to Lambda