Fix the error in generating the idle connection list

encode · Jun 9, 2024 · 077b50d · 077b50d
1 parent e987df2
commit 077b50d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/httpcore/_async/connection_pool.py b/httpcore/_async/connection_pool.py
@@ -251,7 +251,7 @@ def _assign_requests_to_connections(self) -> List[AsyncConnectionInterface]:
                 closing_connections.append(connection)
             elif (
                 connection.is_idle()
-                and len([connection.is_idle() for connection in self._connections])
+                and len([connection for connection in self._connections if connection.is_idle()])
                 > self._max_keepalive_connections
             ):
                 # log: "closing idle connection"

diff --git a/httpcore/_sync/connection_pool.py b/httpcore/_sync/connection_pool.py
@@ -251,7 +251,7 @@ def _assign_requests_to_connections(self) -> List[ConnectionInterface]:
                 closing_connections.append(connection)
             elif (
                 connection.is_idle()
-                and len([connection.is_idle() for connection in self._connections])
+                and len([connection for connection in self._connections if connection.is_idle()])
                 > self._max_keepalive_connections
             ):
                 # log: "closing idle connection"