-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure pool timeout is applied, even after attempts leading to ConnectionNotAvailable #823
Conversation
ac8bd4c
to
ee12daa
Compare
0c49e79
to
10742de
Compare
I believe that changes such as "quote to double quote" are unnecessary in this pull request. The implementation makes sense, but the test cases are overly complicated; we could probably write them much more simply. |
fc79e17
to
9fa759d
Compare
ce92bcf
to
cb112af
Compare
Let's just use the previous test case. I have tried to write a simple test for these cases, but it seems like we should avoid that. |
@karpetrosyan I understand, let me check if it can be isolated/simplified |
cb112af
to
c28f67a
Compare
tests reverted and Changelog added |
This is great. Thank you @valsteen! |
…tionNotAvailable (encode#823) * add failing tests * fix pooltimeout * Revert "add failing tests" This reverts commit cacc248. * mark `if timeout < 0` as not covered, since the test is reverted * Update CHANGELOG.md
Summary
fixes #822
This ensures the total time spent trying to acquire a connection is considered.
add failing tests
contains a failing test case demonstrating the issue. The second commit fixes it0
will succeed if a connection is immediately availableChecklist