Add support for multiple files per POST field #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euri10
commented
Jun 24, 2020
httpx/_content_streams.py
Outdated
| @@ -328,7 +328,8 @@ def _iter_fields( | |||
| else: | |||
| yield self.DataField(name=name, value=value) | |||
|
|
|||
| for name, value in files.items(): | |||
| file_items = files.items() if isinstance(files, dict) else files | |||
| for name, value in file_items: # type: ignore | |||
There was a problem hiding this comment.
No idea how to fix the mypy error on this line httpx/_content_streams.py:332: error: Unpacking a string is disallowed
There was a problem hiding this comment.
I think it’s because the type hints is using Mapping but we’re only matching against dict (a specific type of mapping), so mypy assumes that the other branch could also receive other types of mappings, and iterating over a mapping yields its keys (strings).
It’s actually possible to isinstance(obj, typing.Mapping) (since it’s the same Mapping class than in collections.abc), so I think we can go for that?
Alternatively, switch the if to match a tuple (and treat the default case as mapping) - probably a bit less surprising.
florimondmanca
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #777
inspired by great work done on #891
separates files and data as per @florimondmanca suggesiton in gitter
I commented below a mypy error I ignored because I'm clueless on how to deal with it to be honest