-
-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differentiate between 'url.host' and 'url.raw_host' #1590
Conversation
Wouldn't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple typos, and the previous question about what raw
means.
Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com>
Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com>
Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com>
Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com>
Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com>
Raw, as in the "the raw bytes on the wire", or "the raw ingredients that make up the cake". Or, in baking... The raw ingredients: Similar usage of "Raw" in other technical docs. |
Thanks so much for the review @StephenBrown2. |
I think it was mainly just a copy-paste issue that got propagated, but no more |
Refs #1275
Throughout our URL model we're differentiating neatly between byte-wise cases and str cases.
We're always using bytes when escaping is not applied, and str when escaping is applied.
Eg...
This pull request is a proposal for treating IDNA domain names similarly, so...
For API consistency this also necessarily results in
url.netloc
becoming a byte interface, which actually makes sense for the contexts in which it is used.Finally we also introduce
.raw_scheme
for a byte-wise representation of the scheme, for a nice consistency so that: