Unify BaseReader and BaseWriter as BaseStream #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florimondmanca
force-pushed
the
refactor/stream-interface
branch
2 times, most recently
from
eaee237 to
49369f3
Compare
|
Great stuff! I think that our stream interface should also encapsulate the http version info, (eg `get_protocol_info() -> str) so that instead of connect returning a two tuple of (Stream, str), it can just return Stream. |
|
Oh sure, good idea — didn't see that the protocol refactor got in. 👍 |
florimondmanca
force-pushed
the
refactor/stream-interface
branch
from
49369f3 to
fdb1359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a suggestion from @tomchristie in #217 (comment), simplifies the stream interface by merging
BaseReaderandBaseWriterinto a unified stream interface.