-
-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ruff format #2901
Use ruff format #2901
Conversation
Announcement: https://astral.sh/blog/the-ruff-formatter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to 88 back, please. At least let's discuss first.
Also, what's the time black takes to format httpx?
It was 120 originally, and I just reverted that change 😕 .
I don't think it matters; we just have an opportunity to get rid of the extra dependency. |
It was 120 on linting... It was 88 on format. |
How do you want me to do it? Both the formatter and the linter have a single line length. I'm not sure what the "change back to 88" even means here. Setting the formatter line length equal to the linter line length feels more natural to me. |
e399490
to
f9d2b86
Compare
Okay, I used the solution that @T-256 suggested, which was to use the max-line-length provided by the Later, I'll start a discussion about enforcing limits to the same number. |
Ruff introduced a new formatter that can completely replace black, allowing us to use ruff instead of ruff + black.
Ruff formatter, like ruff linter, is extremely fast.