Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention NO_PROXY environment variable on Advanced Usage page #3066

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

RichieB2B
Copy link
Contributor

Summary

The NO_PROXY environment variable is not mentioned at all on the Advanced Usage page, only on the Environment Variables page. This PR adds it so it is clear right away this environment variable is used by httpx.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Copy link
Contributor

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@karpetrosyan karpetrosyan merged commit 37a2901 into encode:master Jan 30, 2024
5 checks passed
@RichieB2B RichieB2B deleted the no-proxy branch January 30, 2024 12:07
shepilov-vladislav pushed a commit to shepilov-vladislav/httpx that referenced this pull request Mar 28, 2024
…3066)

Co-authored-by: Kar Petrosyan <92274156+karpetrosyan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants