[Superseded] Move type definitions to a dedicated module #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
florimondmanca
commented
Mar 28, 2020
Comment on lines
+284
to
+285
| for name, filevalue in files.items(): | ||
| yield self.FileField(name=name, value=filevalue) |
There was a problem hiding this comment.
Different variable name to value is required of mypy would complain that the value in data doesn't have the same type as the value in files (but ideally we don't want to just use Any here).
florimondmanca
force-pushed
the
types-module
branch
from
6c2bd25
to
7fdef17
Compare
|
Realizing that this might become largely reduced in scope once #804 is in, so let's wait… |
florimondmanca
changed the title
|
Closed in favor of #902 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #789 (comment)
Also improves/fixes the typing information in the multipart stream implementation, as some of it was actually wrong.