Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional routes are not working anymore because the
?
gets escaped by the change introduced in: f12e237This code handle that scenario by looking at the last character of the path before doing the escape.
When the last character is a
?
it will do the escape on the path and prevent the escape of the needed?
.I've added test to verify that optional routes are now working alongside the regexp meta character in path changes.
If you feel this change is not welcome, please close the PR but since it was a "very clearly well identified bug" It felt appropriate.
This PR fixes #1008