Update GraphiQL template in GraphQLApp #1086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GraphiQL editor bundled with Starlette is obsolete and doesn't support modern utilities. The HTML template for the editor has been updated with the example from GraphiQL's repo: https://github.com/graphql/graphiql/blob/main/examples/graphiql-cdn/index.html This example has been modified to enable the editor's functionality to manage the headers of the requests.
|
Sorry about all the formating commits; didn't know about Black. |
|
Thank you for creating this pull request. We have decided to deprecate GraphQL support within Starlette itself so I am going to close this pull request. See #619. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GraphiQL editor bundled with Starlette is obsolete and
doesn't support modern utilities. The HTML template for the
editor has been updated with the example from GraphiQL's repo:
https://github.com/graphql/graphiql/blob/main/examples/graphiql-cdn/index.html
This example has been modified to enable the editor's
functionality to manage the headers of the requests.
See graphql/graphiql#59 (comment)