Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add union operators to MutableHeaders #1240

Merged
merged 6 commits into from
Feb 16, 2022
Merged

Add union operators to MutableHeaders #1240

merged 6 commits into from
Feb 16, 2022

Conversation

manlix
Copy link
Contributor

@manlix manlix commented Jul 6, 2021 •
edited by Kludex
Loading

Fix for issue #1239

Edit by @Kludex: Closes #1239

@manlix manlix force-pushed the headers_merge branch 2 times, most recently from 102c22d to 95551e8 Compare July 21, 2021 20:09
Kludex
Kludex previously requested changes Jan 9, 2022
View reviewed changes
starlette/datastructures.py Outdated Show resolved Hide resolved
@Kludex
Copy link
Member

Kludex commented Jan 9, 2022

@manlix Are you still interested in this PR? If so, would you mind rebasing and checking my comment?

@manlix manlix force-pushed the headers_merge branch 2 times, most recently from e7e81d4 to 06e0963 Compare January 9, 2022 22:07
@manlix manlix requested a review from Kludex January 9, 2022 22:11
@manlix
Copy link
Contributor Author

manlix commented Jan 9, 2022

@Kludex Thank you for your suggest. PR has been updated + new tests bundle.

@manlix manlix force-pushed the headers_merge branch 2 times, most recently from 74c77e7 to 25e1143 Compare January 10, 2022 05:56
@adriangb adriangb added the feature New feature or request label Feb 2, 2022
@tomchristie
Apply suggestions from code review
2e6c037 
* Use `TypeError`, not `NotImplemented`.
* Add `# type: ignore` to deliberate incorrect usage of types in tests.
tomchristie
tomchristie approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 - Great thanks!
Made some minor tweaks. (TypeError, not NotImplemented)

@tomchristie tomchristie merged commit b1ae0c3 into encode:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcwilson jcwilson jcwilson left review comments

@tomchristie tomchristie tomchristie approved these changes

@Kludex Kludex Awaiting requested review from Kludex

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to merge MutableHeaders with dict
5 participants
@manlix @Kludex @jcwilson @tomchristie @adriangb