Bugfix of regex at FloatConvertor

[i-Ching]

1. ValueError: could not convert string to float if path parameters '/path/{number:float}' like /path/1-1, /path/2+2, /path/3^3

2. Bug: A dot in regex of class FloatConvetor is also a metacharacter, it is used to match any character.

3. Fix: I need to add a backslash escape the dot, so regex = "[0-9]+(\.[0-9]+)?"

The starting point for contributions should usually be a discussion

Simple documentation typos may be raised as stand-alone pull requests, but otherwise please ensure you've discussed your proposal prior to issuing a pull request.

This will help us direct work appropriately, and ensure that any suggested changes have been okayed by the maintainers.

• Initially raised as discussion #...

[Kludex]

Would you mind adding a test for it?

[i-Ching]

Would you mind adding a test for it?

Below is the simple test.py, I curl http://localhost:8000/path/1.1 is passed, but http://localhost:8000/path/2-2 raises 500 Server Error: ValueError: could not convert string to float: '2-2'

from starlette.applications import Starlette
from starlette.responses import JSONResponse
from starlette.routing import Route
import uvicorn

async def homepage(request):
    return JSONResponse(request.path_params)

app = Starlette(debug=True, routes=[
    Route('/path/{number:float}', homepage),
])
if __name__ == "__main__":
 uvicorn.run(app)

[i-Ching]

Sorry my bad, I deleted my fork to affect to close this pull request. It is related to the bugfix of #1944.
I reopen here and wait for your approval.

[iudeen]

#1944 has the same goal, can we close this and continue there?