Add HTTP range headers to FileResponse
#2367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
commented
Dec 10, 2023
| units, range_ = http_range.split("=", 1) | ||
| units = units.strip().lower() | ||
|
|
||
| if units != "bytes": |
There was a problem hiding this comment.
If other unit is provided, should error for the time being.
Kludex
force-pushed
the
file-response-range
branch
from
60269bd
to
1c6254e
Compare
|
Closing it for now. |
Kludex
force-pushed
the
file-response-range
branch
from
1c6254e
to
879f91d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP