-
-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ASGI pathsend
extension
#2435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need tests.
@abersheeran is this the only thing needed on the implementation side?
Yes, its actual logic implementation is all on the server side. |
58c7cde
to
30989e0
Compare
@Kludex I added a test for this, but it only test the correctness of the messages as |
Reference of the previous PR regarding this extension: #1288 |
OHHHH, this is the one you created. Sorry! |
Thanks @gi0baro 🙏 |
* add support for ASGI `pathsend` extension * add test for ASGI `pathsend`
This reverts commit 7936e86.
Summary
As per title, this adds support for ASGI pathsend extension on
FileResponse
class for servers implementing it.Checklist