Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore old documented functionality, add optional warning, document the warning #2486

Closed
wants to merge 2 commits into from

Conversation

rambo
Copy link

@rambo rambo commented Feb 6, 2024

Summary

As per #2446 the new "raise by default" broke a ton of containerized apps where environment is used in the container but developers use .env files locally.

This will restore old documented functionality to a pattern that is just about everywhere but also adds an option to issue warning if the file is missing.

IDK why coverage on CI is being a silly bugger, my local coverage report says all modified code paths are covered

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@rambo rambo marked this pull request as draft February 6, 2024 21:30
@rambo rambo changed the title DRAFT: Restore old documented functionality, add optional warning, document the warning Restore old documented functionality, add optional warning, document the warning Feb 6, 2024
@rambo rambo marked this pull request as ready for review February 6, 2024 21:54
@Kludex
Copy link
Sponsor Member

Kludex commented Feb 6, 2024

I prefer the approach on #2485.

Thanks for the PR.

@Kludex Kludex closed this Feb 6, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants