Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: check endpoint handler is async only once #2536

Merged
merged 3 commits into from
Apr 20, 2024
Merged

refactor: check endpoint handler is async only once #2536

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c9bbba
refactor: check endpoint handler is async only once
sk- Mar 7, 2024
ab53a16
Apply PR suggestion
sk- Mar 21, 2024
cd37ae2
Merge branch 'master' into refactor/check_async_once
Kludex Apr 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions starlette/routing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,15 @@ def request_response(
Takes a function or coroutine `func(request) -> response`,
and returns an ASGI application.
"""
f: typing.Callable[[Request], typing.Awaitable[Response]] = (
func if is_async_callable(func) else functools.partial(run_in_threadpool, func) # type:ignore
)

async def app(scope: Scope, receive: Receive, send: Send) -> None:
request = Request(scope, receive, send)

async def app(scope: Scope, receive: Receive, send: Send) -> None:
if is_async_callable(func):
response = await func(request)
else:
response = await run_in_threadpool(func, request)
response = await f(request)
await response(scope, receive, send)

await wrap_app_handling_exceptions(app, request)(scope, receive, send)
Expand Down