-
-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coverage: pin higher coverage #1006
Conversation
there is something going on with the windows CI, any idea ? I have |
Yes, it was working before because I've removed the marker for |
Looks like Windows is supported by |
cool ! |
* coverage: pin higher coverage * add more ignores * not change previous code * remove marker on httptools * fix requirement
The file
httptools_impl.py
is not covered by windows, the reason for it is the marker that was added on #309.But after removing the marker, it worked... 🤔
Previous Windows coverage: 86% (due mostly to the file mentioned above).
Coverage achieved: 95%.
Related issue: #102
I still don't like this, I think the "heavyweight tooling approaches" makes more sense, but... Here you have @tomchristie .
I've also learned about the
compat.py
, but it will not solve the issue with thehttptools_impl.py
and it will change slightly the structure of files (loops/asyncio.py
might cease to exist).Well, I can just add a
no pragma
for the wholehttptools_impl.py
file if the removal of the marker is not accepted, but I don't think we want that...