Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage: pin higher coverage #1006

Merged
merged 7 commits into from
May 28, 2021
Merged

coverage: pin higher coverage #1006

merged 7 commits into from
May 28, 2021

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Mar 12, 2021

The file httptools_impl.py is not covered by windows, the reason for it is the marker that was added on #309.

But after removing the marker, it worked... 🤔

Previous Windows coverage: 86% (due mostly to the file mentioned above).
Coverage achieved: 95%.

Related issue: #102

I still don't like this, I think the "heavyweight tooling approaches" makes more sense, but... Here you have @tomchristie .

I've also learned about the compat.py, but it will not solve the issue with the httptools_impl.py and it will change slightly the structure of files (loops/asyncio.py might cease to exist).

Well, I can just add a no pragma for the whole httptools_impl.py file if the removal of the marker is not accepted, but I don't think we want that...

@Kludex Kludex marked this pull request as ready for review March 12, 2021 18:29
@Kludex Kludex marked this pull request as draft March 12, 2021 18:40
@Kludex Kludex marked this pull request as ready for review March 12, 2021 18:50
@Kludex Kludex marked this pull request as draft March 12, 2021 20:12
@Kludex Kludex marked this pull request as ready for review March 12, 2021 20:56
@Kludex Kludex self-assigned this May 28, 2021
@Kludex Kludex requested review from euri10 and removed request for euri10 May 28, 2021 17:19
@euri10
Copy link
Member

euri10 commented May 28, 2021

there is something going on with the windows CI, any idea ?

I have
uvicorn/protocols/http/httptools_impl.py 311 11 96% 115-116, 143-144, 148, 300, 306, 404, 407, 439, 441 on my machine and it's 2% on the windows CI

@Kludex
Copy link
Member Author

Kludex commented May 28, 2021

Yes, it was working before because I've removed the marker for httptools on Windows. I'm checking what I said previously (on the description above).

@Kludex
Copy link
Member Author

Kludex commented May 28, 2021

Ok... https://github.com/MagicStack/httptools/blob/40404907f2714c4463aca35f3d258efdbb417fb3/setup.py#L187

Looks like Windows is supported by httptools...

@Kludex Kludex requested a review from euri10 May 28, 2021 17:45
@euri10 euri10 merged commit 4c485cc into encode:master May 28, 2021
@euri10
Copy link
Member

euri10 commented May 28, 2021

cool !

Kludex added a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
* coverage: pin higher coverage

* add more ignores

* not change previous code

* remove marker on httptools

* fix requirement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants