Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subprocess module tests #1122

Closed
wants to merge 7 commits into from
Closed

Add subprocess module tests #1122

wants to merge 7 commits into from

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Jul 12, 2021

No description provided.

@Kludex Kludex changed the title ✅ Add subprocess stated test ✅ Add subprocess started test Jul 12, 2021
@Kludex Kludex mentioned this pull request Jul 12, 2021
Closed
@Kludex Kludex changed the title ✅ Add subprocess started test ✅ Add subprocess module tests Jul 12, 2021
@Kludex Kludex requested a review from euri10 July 22, 2021 09:51
@Kludex Kludex marked this pull request as ready for review July 22, 2021 09:51
Kludex
Kludex commented Jul 22, 2021
View reviewed changes
tests/test_subprocess.py

process = get_subprocess(config, server_run, [fdsock])
assert isinstance(process, SpawnProcess)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I'm not terminating the process anymore...

@Kludex Kludex changed the title ✅ Add subprocess module tests Add subprocess module tests Jul 30, 2021
@Kludex
Copy link
Member Author

Kludex commented Apr 23, 2022

This branch no longer exists due to a previous removal of my fork. 😅

@Kludex Kludex closed this Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euri10 euri10 Awaiting requested review from euri10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Kludex