Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 100% cover to uvicorn/main.py #1154

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Conversation

humrochagf
Copy link
Contributor

  • Mostly test main as a cli client
  • Test main functions directly when it's impossible to do is as a cli client (i.e. app non string case)
  • Add no cover to the module entrypoint main call

Related to: #102

- Mostly test main as a cli client
- Test main functions directly when it's impossible to do is as a cli client (i.e. app non string case)
- Add no cover to the module entrypoint main call

Related to: encode#102
@Kludex Kludex mentioned this pull request Aug 16, 2021
Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@humrochagf Thank you very much for this! :)

@Kludex Kludex merged commit 72dffc7 into encode:master Aug 16, 2021
Kludex pushed a commit that referenced this pull request Nov 17, 2021
- Mostly test main as a cli client
- Test main functions directly when it's impossible to do is as a cli client (i.e. app non string case)
- Add no cover to the module entrypoint main call

Related to: #102
Kludex pushed a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
- Mostly test main as a cli client
- Test main functions directly when it's impossible to do is as a cli client (i.e. app non string case)
- Add no cover to the module entrypoint main call

Related to: encode#102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants