Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate WSGIMiddleware #1235

Closed
wants to merge 3 commits into from
Closed

Deprecate WSGIMiddleware #1235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f66b533
Deprecate WSGIMiddleware
abersheeran Nov 6, 2021
25b4178
fixed pep8
abersheeran Nov 6, 2021
e581e04
fix DeprecationWarning
abersheeran Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ filterwarnings=
error
# Workaround for Python 3.9.7 (see https://bugs.python.org/issue45097)
ignore:The loop argument is deprecated since Python 3\.8, and scheduled for removal in Python 3\.10\.:DeprecationWarning:asyncio
ignore:The built-in `WSGIMiddleware` will be deprecated in future versions, please use `a2wsgi.WSGIMiddleware` instead.:DeprecationWarning

[coverage:run]
omit = venv/*
Expand Down
7 changes: 7 additions & 0 deletions uvicorn/middleware/wsgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import concurrent.futures
import io
import sys
import warnings
from collections import deque
from typing import Deque, Iterable, Optional, Tuple

Expand All @@ -18,6 +19,12 @@

from uvicorn._types import Environ, ExcInfo, StartResponse, WSGIApp

warnings.warn(
"The built-in `WSGIMiddleware` will be deprecated in"
" future versions, please use `a2wsgi.WSGIMiddleware` instead.",
DeprecationWarning,
)


def build_environ(scope: HTTPScope, message: ASGIReceiveEvent, body: bytes) -> Environ:
"""
Expand Down