Fix coverage precision to 96.77% #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I may have a few rounds of commits to add pragma coverage conditional, so I can match the Ubuntu Python 3.8 coverage. |
Kludex
changed the title
Kludex
added a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
* Fix coverage precision to 96.83% * Add conditional coverage rule * Modify fail-under to check if 3.7 passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Aren't you being too pedantic?"
Not really... It's really bothersome having to regain the same coverage over and over again because PRs get merged without covering all of it. The idea here is to not regress anymore.
coveragedoesn't support the precision argument on the CLI. I've created a PR to fix it: nedbat/coveragepy#1317. Until then, we should use thesetup.cfg.