Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs refresh #1365

Merged
merged 6 commits into from
Feb 8, 2022
Merged

Docs refresh #1365

merged 6 commits into from
Feb 8, 2022

Conversation

tomchristie
Copy link
Member

  • Push back on "performance". A bit silly really. Was important at one point in order to demonstrate that the ASGI approach was not any worse than tightly integrated alternatives. But we've established that point now.
  • Drop "Support for HTTP/2 is planned".
  • Add "Why ASGI" section to better provide the rationale for the ASGI ecosystem.
  • Include "Alternative ASGI servers" on the README (as well as the existing section on the homepage.)
  • Drop "Designed & built in Brighton, England." - I think there's some validity to design approaches that have a strong initial author voice, because it helps establish a clear direction and design intent, but it's also diminishing to the vast number of folks who've worked on it over the years, and the multitude of contributions of all different kinds that make it possible.

@tomchristie tomchristie added the docs Improve documentation label Feb 7, 2022
@tomchristie tomchristie requested a review from a team February 7, 2022 14:50
Copy link
Member

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra file added docs/.DS_Store.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes complete sense. 👍

README.md Outdated Show resolved Hide resolved
Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
docs/index.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
@tomchristie
Copy link
Member Author

Thanks folks! Comments addressed.
I've also bumped up encode/starlette#1477 which is similar.

README.md Outdated Show resolved Hide resolved
@tomchristie tomchristie requested a review from a team February 8, 2022 15:28
@tomchristie tomchristie merged commit 9206350 into master Feb 8, 2022
@tomchristie tomchristie deleted the docs-tweaks branch February 8, 2022 16:47
Kludex pushed a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improve documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants