Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match coverage between systems #1458

Merged
merged 3 commits into from
May 3, 2022
Merged

Match coverage between systems #1458

merged 3 commits into from
May 3, 2022

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Apr 26, 2022 •
edited
Loading

Changes:

  • Move coverage report settings to setup.cfg.
  • Match coverage between Python versions and platforms.

@Kludex Kludex changed the title Pass coverage parameters on setup.cfg Match coverage between systems Apr 26, 2022
@Kludex Kludex requested a review from euri10 April 26, 2022 20:25
@Kludex Kludex modified the milestone: Version 0.18.0 Apr 27, 2022
@Kludex Kludex requested a review from a team April 28, 2022 06:35
br3ndonland
br3ndonland approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@br3ndonland br3ndonland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small suggestion, otherwise LGTM

setup.cfg Show resolved Hide resolved
@Kludex Kludex merged commit 843a6ac into master May 3, 2022
@Kludex Kludex deleted the coverage-setup branch May 3, 2022 06:09
Kludex added a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
@Kludex
Match coverage between systems (encode#1458)
93a9558 
* Pass coverage parameters on setup.cfg

* Drop coverage to match ubuntu 3.8

* Add pragma: py-linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@br3ndonland br3ndonland br3ndonland approved these changes

@euri10 euri10 Awaiting requested review from euri10

Assignees
No one assigned
Labels
clean up tooling
Projects
None yet
Milestone
Version 0.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Kludex @br3ndonland