-
-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SSLContext factory #1815
Closed
Closed
Changes from 12 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
6635a74
adding list of options to ssl_context
aswanidutt e3de724
Merge branch 'encode:master' into master
aswanidutt87 33aef83
adding unit tests, coverage - 97.71%
aswanidutt 9d9069e
linting, doc updates, cleanup
aswanidutt 33d464e
removed from load and added in create_ssl_context
aswanidutt 904ecb1
adding help content
aswanidutt 5fd40f8
Merge branch 'encode:master' into master
aswanidutt87 264852d
adding custom ssl_context via factory pattern
aswanidutt 5da1a3d
ignoring setup
aswanidutt 208e581
code changes with review comments updated
aswanidutt bf1e78e
adding ssl_context to update with parameters passed
aswanidutt 8370271
Merge remote-tracking branch 'upstream/master'
aswanidutt 264fc9f
updating cyrptography due to a cve
aswanidutt cf71c25
Merge remote-tracking branch 'upstream/master'
aswanidutt 4abc589
Merge branch 'master' into issue-#806
aswanidutt87 9948eda
Merge remote-tracking branch 'upstream/master'
aswanidutt 40e58a0
fixing imports
aswanidutt e1258d7
Merge remote-tracking branch 'upstream/master'
aswanidutt 1a2e7a3
merge from master
aswanidutt bc8adbb
changing to str
aswanidutt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can't be a callable. What I said was to load the function object from the path... Which I'm not sure if we really should make this available via CLI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are messages I've written here that you ignored. I'm not reviewing this again without them addressed.
The code changes here don't fully take in consideration my previous comments.