Handle missing trustme/cryptography gracefully in the test suite #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgorny
force-pushed
the
opt-cryptography
branch
from
e970dc3 to
1ae1b4e
Compare
mgorny
commented
Apr 12, 2023
Skip tests requiring trustme/cryptography if either of the packages are not installed. This makes it possible to run most of the test suite on architectures that do not feature a working Rust toolchain at the time.
mgorny
force-pushed
the
opt-cryptography
branch
from
1ae1b4e to
cc8332a
Compare
Kludex
requested changes
Apr 12, 2023
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
|
Thanks. Please lemme know if I should rebase. |
Kludex
approved these changes
Apr 12, 2023
|
Thanks Michał 🙏 With similar subjects, you can create a PR directly, no need for discussions. 👍 |
|
Do you need me to make a release, or can you already make use of those changes? |
|
Thanks. We already have a hack in place, so no hurry for a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip tests requiring trustme/cryptography if either of the packages are not installed. This makes it possible to run most of the test suite on architectures that do not feature a working Rust toolchain at the time.