Drop support for Python 3.7 #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
Thoughts on including a warning about this first? e.g. https://github.com/PrefectHQ/prefect/blob/382ebdcc54b1a45ce6e4cc0dfcfaf1fd09939ead/src/prefect/__init__.py#L23-L34
Since we change the "requires-python" value, I don't think that's needed. Also, is there someone that does the same besides Prefect? |
|
@Kludex I think that just means pip won't pick up new versions if the user is on 3.7 which could be confusing without any additional context 🤷♀️ I don't know of other projects that are displaying a warning though. I don't think it's a big deal — Prefect has a lot more beginner-level users. |
Kludex
force-pushed
the
burn/drop-python-3.7
branch
from
1adb1c2
to
21e550a
Compare
Kludex
force-pushed
the
burn/drop-python-3.7
branch
from
21e550a
to
45722cf
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Python 3.7 EOL is approaching: https://endoflife.date/python.
This PR drops support for Python 3.7.