Allow setting APP with envvar UVICORN_APP #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
approved these changes
Sep 21, 2023
|
Thanks @aceat64 :) |
br3ndonland
added a commit
to br3ndonland/inboard
that referenced
this pull request
Dec 31, 2023
Uvicorn 0.24.0 adds support for setting the app instance with the environment variable `UVICORN_APP`. inboard already has an environment variable for this purpose, `APP_MODULE`. This commit will add support for `UVICORN_APP`. Either `APP_MODULE` or `UVICORN_APP` can be used to set the app module for inboard, with precendence given to `APP_MODULE` for backward compatibility. https://github.com/encode/uvicorn/releases/tag/0.24.0 encode/uvicorn#2106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows configuring the
APPsetting using the environment variableUVICORN_APP. Currently environment variables can be used for all other settings thanks to click'sauto_envvar_prefix, but this applies only to options and not to arguments.Checklist
I'm not sure if a new test is needed for this change. Additionally, I believe no documentation changes are needed. The docs currently state that env vars can be used for configuration but doesn't call out the caveat that
APPcan not.