Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly annotate uvicorn.run() #2158

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Properly annotate uvicorn.run() #2158

merged 3 commits into from
Nov 22, 2023

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Nov 21, 2023

I know I closed this #1855, but I don't think another type check for the run() function.

@Kludex Kludex requested a review from a team November 21, 2023 13:30
uvicorn/config.py Outdated Show resolved Hide resolved
@Kludex Kludex requested a review from abersheeran November 21, 2023 14:28
@Kludex Kludex merged commit 09e1948 into master Nov 22, 2023
15 checks passed
@Kludex Kludex deleted the fix-uvicorn-run branch November 22, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants