Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(readme): add granian as an alternative #2359

Merged
merged 4 commits into from
Jun 14, 2024
Merged

docs(readme): add granian as an alternative #2359

merged 4 commits into from
Jun 14, 2024

Conversation

Zerotask
Copy link
Contributor

@Zerotask Zerotask commented Jun 4, 2024 •
edited
Loading

Summary

  • Update mangum website; current website just shows a blank page
  • Add Granian as an alternative

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Kludex
Kludex reviewed Jun 14, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
Kludex
Kludex approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gi0baro You good with this description?

gi0baro
gi0baro reviewed Jun 14, 2024
View reviewed changes
Copy link

@gi0baro gi0baro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kludex looks a bit polluted, left an alternative suggestion

README.md Outdated Show resolved Hide resolved
@Kludex @gi0baro
Update README.md
4d3a330 
Co-authored-by: Giovanni Barillari <g@baro.dev>
@Kludex
Copy link
Member

Kludex commented Jun 14, 2024

@Kludex looks a bit polluted, left an alternative suggestion

Grazie 🙏

@Kludex Kludex enabled auto-merge (squash) June 14, 2024 10:17
@Kludex Kludex merged commit d79f285 into encode:master Jun 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gi0baro gi0baro gi0baro left review comments

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zerotask @Kludex @gi0baro