Add --app-dir option for running uvicorn from any location #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
My two cents on the --app-dir vs --chdir naming…
The gunicorn description of --chdir is:
Chdir to specified directory before apps loading.
This is not accurately what we do here — we don't cd or really change the working directory. Instead, we allow Python to find the APP in the specified directory by adding it to sys.path.
So --app-dir is probably okay IMO?
Update --app-dir description Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
|
Waiting the approval of this meaningful PR. 😭 //cc @florimondmanca |
& //cc @tomchristie |
tomchristie
reviewed
Jun 9, 2020
|
Yup, I like this, thanks! One query about the phrasing of the help text... should we maybe prefer "Defaults to the current working directory."? |
yezyilomo
deleted the
add_app-dir_option_for_running_uvicorn_from_any_location
branch
This was referenced Mar 14, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to solve #549
I chose
--app-dirto be the name of the option, please let me know if it makes sense, I've also updated the documentation to include--app-diroption, please check if I have added it to the right place.