Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use trace on asgi logger #662

Closed
wants to merge 5 commits into from
Closed

Conversation

euri10
Copy link
Member

@euri10 euri10 commented Apr 30, 2020

This PR does 2 things,

  1. use uvicorn.asgi logger in h11 and httptools protocols instead of uvicorn.error for trace logs
  2. put TRACE_LOG_LEVEL in a single place and import it when needed instead of having it copied everywhere

currently the Connection made and Connection lost messages are written to uvicorn.error

edit: now I have doubts and maybe it's intentional to have to messages at the trace level on the uvicorn.error

euri10 added 5 commits April 30, 2020 17:47
…corn.error for trace logs

Put TRACE_LOG_LEVEL in a single place and import it when needed
…corn.error for trace logs

Put TRACE_LOG_LEVEL in a single place and import it when needed
@euri10 euri10 closed this Oct 6, 2020
@euri10 euri10 deleted the test_logging_correctly branch October 6, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant