Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test config should_reload property #899

Merged
merged 2 commits into from
Dec 19, 2020
Merged

Test config should_reload property #899

merged 2 commits into from
Dec 19, 2020

Conversation

euri10
Copy link
Member

@euri10 euri10 commented Dec 18, 2020

another grind towards #102

the should_reload property of the Config is set to True only if app is imported as a string and debug/reload is set

florimondmanca
florimondmanca reviewed Dec 18, 2020
View reviewed changes
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a separate test, instead of hijacking the one for the debut flag?

@euri10
Copy link
Member Author

euri10 commented Dec 19, 2020

Should we have a separate test, instead of hijacking the one for the debut flag?

yep it makes sense to have separated and more precise tests, I changed

@euri10 euri10 merged commit cdb6873 into encode:master Dec 19, 2020
@euri10 euri10 deleted the upgrade_config_coverage2 branch December 19, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@euri10 @florimondmanca