business/offering data models and helper scripts #174

anizeani · 2022-02-23T13:42:55Z

closes #171
closes #172
Instead of passing the json file path in the terminal, i open a dialog where the user selects the file.. I thought it to be more user friendly.

added business jsons

brenzi · 2022-02-23T18:24:49Z

client/test-data/bazaar/technopark/businesses/KücheEdison.json

@@ -0,0 +1,7 @@
+{
+	"name": "Küche Edison",
+	"description": "wir sind ein lokales Geschäft im Technopark und offerieren köstlichen Kaffe",


this will be visible worldwide. I'd keep it informal "bei uns gibts köstlichen Kaffee". Shouldn't sound serious in any way

brenzi · 2022-02-23T18:29:16Z

client/test-data/bazaar/technopark/offerings/EdisonKaffee.json

@@ -0,0 +1,4 @@
+{


on folder naming:

please replace "technopark" with "EdisonPaula"
subfolders "businesses / offerings do not make sense for me as it isn't clear if you want to group by business and its offerings, or as you did. I suggest to reflect business and product in filenames to reflect the type

i now created a folder structure of test-data/bazaar/business/products, ok?

…dly than pasting the whole path in the terminal

client/test-data/bazaar/EdisonPaula/businesses/küchepauli/KüchePauli.json

…t creation, expect already existing account

…t creation, expect already existing account uploading product.json to ipfs verifying that name and description are present in json file add warning if logo is missing create offering and upload to ipfs

brenzi

please never use umlauts in file/folder names
On the other hand: I would use Umlauts in the Description because that will be a Test we want to pass

client/test-data/bazaar/EdisonPaula/businesses/kücheedison/KücheEdison.json

client/test-data/bazaar/EdisonPaula/businesses/kücheedison/products/EdisonKaffee.json

client/test-data/bazaar/EdisonPaula/businesses/küchepauli/products/PauliKaffee.json

client/upload-image-to-ipfs-and-return-cid.py

brenzi · 2022-02-28T11:04:56Z

client/upload-image-to-ipfs-and-return-cid.py

+        try:
+            image_cid = Ipfs.add(logo_path, ipfs_local)
+        except:
+            print("failed to add image to ipfs")


please exit with an error code and don't just print an error.

see client.py for examples how to do that

I've seen how you check the return codes and depending on them raise a specific error.
in our case we do ipfs.add, which either adds remotely or locally.
In any case we are in an elevated level, so the error would emerge from deeper in code.
So for the curl command (remote ipfs add) there are 96 error return codes. (https://everything.curl.dev/usingcurl/returns)
any of them are actually already handled below, we just need to add the "check" option where the curl command gets excecuted (see my latest file change in file py_client/ipfs.py.
I'm not sure I understand if you want me to handle those errors in the ipfs class by myself, because those errors are actually already handled by the subprocess.run function https://github.com/python/cpython/blob/main/Lib/subprocess.py#L528
what i did now is, enable the error raising in the deeper level and i extend the error output in case of raised error

just define a positive integer number which isn't used already and throw that. Don't care what the exact error was deeper down. just ensure we exit with a positice exit code

update documentation for script

…n format

…ploading to remote ipfs node

… don't get yet why it's there)

brenzi · 2022-02-28T16:35:57Z

Now we have quite a mess of scripts:

register-business-simple (now broken because of path change)
register-businesses (now broken because of path change)
register-business
register-offering
upload-folder-to-ipfs-and-return-cid (sounds generic, but in the help comment it says Register a business on chain)
upload-folder-to-ipfs-and-return-cid

then we also have

publish-icons.py which also just uploads stuff to ipfs

And there is no piece of doc in the README about what to use when and how.

I'll need more time to review and find a solution. Please stop working on this PR for now @anizeani .

…ter offering

…s_and_helper_scripts

brenzi

cleaned up bits and pieces, streamlined and documented. all works locally

added business jsons

824243b

added business jsons

anizeani force-pushed the implement_business_and_offering_data_models_and_helper_scripts branch from 8d6a98f to 824243b Compare February 23, 2022 13:44

add product jsons

76239ba

brenzi reviewed Feb 23, 2022

View reviewed changes

anizeani added 7 commits February 24, 2022 11:54

clean up folder structure, clean up description in businesses

409e912

wip

fd615d5

uplaod single files to ipfs and return cid in terminal

8e649e3

register business by selecting json file, i think its more user frien…

379a56c

…dly than pasting the whole path in the terminal

improve helper text

6b4f5ab

change folder naming

7412ec5

updated jsons

5431767

brenzi reviewed Feb 25, 2022

View reviewed changes

client/test-data/bazaar/EdisonPaula/businesses/küchepauli/KüchePauli.json Outdated Show resolved Hide resolved

anizeani added 6 commits February 28, 2022 08:18

make community identifier and bizaccount required, comment out accoun…

26971f0

…t creation, expect already existing account

make community identifier and bizaccount required, comment out accoun…

59244a4

…t creation, expect already existing account uploading product.json to ipfs verifying that name and description are present in json file add warning if logo is missing create offering and upload to ipfs

removing optional account creation

91dae01

removing optional account creation

78deddd

typo

69b22bd

remove comment

8318135

anizeani requested a review from brenzi February 28, 2022 09:52

brenzi requested changes Feb 28, 2022

View reviewed changes

anizeani added 9 commits February 28, 2022 13:06

remove unused imports, remove prints

84d4526

adding script to upload folders and returns cid

1a8da1c

remove unused imports/path variable,

dac0e93

update documentation for script

updated json files, removed images from git

95c884f

change none to null since none is only python type and not in the jso…

86215be

…n format

updated None to null

d70b4c8

added silent -s option to not display progress bar in terminal when u…

f3c45d6

…ploading to remote ipfs node

silence progress output but show real errors

03a0ce5

updating helper to only display cid and not print empty line (which i…

b6b569b

… don't get yet why it's there)

anizeani added 2 commits February 28, 2022 15:45

add check=True to actually raise error if returncode is != 0

ad7dd35

let error propagate up and return extended error message

1026357

anizeani requested a review from brenzi February 28, 2022 14:51

anizeani added 5 commits February 28, 2022 18:04

update documentation

22718a4

refactoring: now using bazaar.py to enable register business or regis…

4f9268e

…ter offering

refactoring: now using bazaar.py to enable register business or regis…

c0e9dff

…ter offering

remove the two scripts, now one script should do it all

74ea063

remove price as argument

504629f

brenzi mentioned this pull request Aug 22, 2022

unify monorepository #251

Open

brenzi and others added 3 commits April 14, 2023 13:29

Merge branch 'master' into implement_business_and_offering_data_model…

c273094

…s_and_helper_scripts

cleanup and docs

7ce5515

let CI fail if registering biz or offerings fails

a109e05

brenzi approved these changes Apr 14, 2023

View reviewed changes

brenzi merged commit 2bc5eb1 into master Apr 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

business/offering data models and helper scripts #174

business/offering data models and helper scripts #174

anizeani commented Feb 23, 2022 •

edited

Loading

brenzi Feb 23, 2022

brenzi Feb 23, 2022

anizeani Feb 28, 2022

brenzi left a comment

brenzi Feb 28, 2022

brenzi Feb 28, 2022

anizeani Feb 28, 2022 •

edited

Loading

brenzi Feb 28, 2022

brenzi commented Feb 28, 2022

brenzi left a comment

business/offering data models and helper scripts #174

business/offering data models and helper scripts #174

Conversation

anizeani commented Feb 23, 2022 • edited Loading

brenzi Feb 23, 2022

Choose a reason for hiding this comment

brenzi Feb 23, 2022

Choose a reason for hiding this comment

anizeani Feb 28, 2022

Choose a reason for hiding this comment

brenzi left a comment

Choose a reason for hiding this comment

brenzi Feb 28, 2022

Choose a reason for hiding this comment

brenzi Feb 28, 2022

Choose a reason for hiding this comment

anizeani Feb 28, 2022 • edited Loading

Choose a reason for hiding this comment

brenzi Feb 28, 2022

Choose a reason for hiding this comment

brenzi commented Feb 28, 2022

brenzi left a comment

Choose a reason for hiding this comment

anizeani commented Feb 23, 2022 •

edited

Loading

anizeani Feb 28, 2022 •

edited

Loading