Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add netcat to Dockerfile-node for websocket healthchecks. #303

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

clangenb
Copy link
Member

Closes #302

Dockerfile-node Outdated
RUN apt-get update && \
apt-get install -y jq
# Install netcat for websocket healthcheck
RUN apt-get update && apt-get install -yq jq netcat
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather use apt update/install instead of apt-get update/install

@clangenb clangenb force-pushed the cl/add-netcat-for-healthcheck branch from 5f38ab2 to 000ca35 Compare March 21, 2023 09:07
Copy link
Collaborator

@mosonyi mosonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clangenb clangenb merged commit 54916c2 into master Mar 22, 2023
@clangenb clangenb deleted the cl/add-netcat-for-healthcheck branch September 12, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in the docker image possibilities to ensure that the node service is running
2 participants