Democracy #350
Democracy #350
Conversation
pifragile
commented
Sep 18, 2023
pifragile
commented
- Closes integrate democracy #347
pifragile
force-pushed
the
democracy
branch
from
fba1afc
to
e8e83a2
Compare
| #phase is 9, registering | ||
| print(client.purge_community_ceremony(cid, 1, 8)) | ||
| register_participants_and_perform_meetup(client, cid, accounts) | ||
| cindex = 9 |
There was a problem hiding this comment.
that's brittle. we should not assume the same order of tests forever.
There was a problem hiding this comment.
this is exactly why i have been saying for a long time that we need to refactor the integration tests :)
| client.update_proposal_state("//Alice", 1) | ||
| proposals = client.list_proposals() | ||
| print(proposals) | ||
| if('Approved' not in proposals): |
There was a problem hiding this comment.
within the same testing time we could test 3 parallel proposals to increase test coverage:
- 2x Aye, 1x Nay
- 1x Aye, 2x Nay
- no votes
Moreover, it would be nice to test enactment too, not just approval
(pardon, I know you haven't asked for the review just yet ;-)
There was a problem hiding this comment.
sure! now in the light of very limited time remaining from my side, where to put the focus? this, or the remaining tasks for the accounting dashboard?
There was a problem hiding this comment.
updated tracking issue accordningly
encointer/pallets#347
