Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[democracy] move proposal enaction to the start of assigning phase #393

Closed
brenzi opened this issue Jun 2, 2024 · 2 comments · Fixed by #397
Closed

[democracy] move proposal enaction to the start of assigning phase #393

brenzi opened this issue Jun 2, 2024 · 2 comments · Fixed by #397
Assignees

Comments

@brenzi
Copy link
Member

brenzi commented Jun 2, 2024

The current implementation enacts at the beginning of registering phase. This leads to inconsistent rewards if the proposal adjusts community issued income as some may claim early (during attesting) and others during registering (late claim).

Options:

  • at start of registering.
    • con: see above: potentially inconsistent CII
  • at start of assigning.
    • pro: allows swift adding of new locations (only if onCeremonyPhaseChange is executed before ceremony pallet where assignment happens: must be well documented). In emergencies, a proposal could be submitted and approved during a single registering phase and enacted for the same cycle)
    • con: none
  • at start of attesting.
    • con: possible inconsistency if assigning had different rules than meetup evaluation
@brenzi
Copy link
Member Author

brenzi commented Jun 2, 2024

@pifragile any considerations to add?

@pifragile
Copy link
Contributor

seems legit @brenzi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants