Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[democracy] several fixes and enhancements #397

Merged
merged 8 commits into from
Jun 25, 2024
Merged

[democracy] several fixes and enhancements #397

merged 8 commits into from
Jun 25, 2024

Conversation

brenzi
Copy link
Member

@brenzi brenzi commented Jun 24, 2024 •
edited
Loading

closes #393
closes #392
closes #391
closes #390

  • needs storage migration
  • will allow very lazy update: a proposal with fulfilled confirming phase will be scheduled for enactment even if update is called after its lifetime ended - unless it has been superseded

@brenzi brenzi added enhancement New feature or request labels Jun 24, 2024
@brenzi brenzi changed the title move enactment of approved proposals to start of assigning phase [democracy] several fixes and enhancements Jun 24, 2024
@brenzi
Copy link
Member Author

brenzi commented Jun 24, 2024

@pifragile FYI. I had to move on.....

@brenzi brenzi requested a review from clangenb June 24, 2024 14:33
clangenb
clangenb approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

communities/src/lib.rs Show resolved Hide resolved
democracy/src/lib.rs Outdated Show resolved Hide resolved
democracy/src/lib.rs Show resolved Hide resolved
democracy/src/migrations.rs Show resolved Hide resolved
democracy/src/migrations.rs Show resolved Hide resolved
@clangenb clangenb mentioned this pull request Jun 25, 2024
Merged
@brenzi brenzi merged commit 9e700c8 into master Jun 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

Assignees
No one assigned
Labels
E2-needs_state_migration enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@brenzi @clangenb