Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix assignment bug #346

Merged
merged 3 commits into from
Aug 24, 2023
Merged

fix assignment bug #346

merged 3 commits into from
Aug 24, 2023

Conversation

pifragile
Copy link
Contributor

clangenb
clangenb reviewed Aug 23, 2023
View reviewed changes
Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome catch, I only noted a cosmetic issue.

ceremonies/assignment/src/lib.rs Show resolved Hide resolved
ceremonies/src/tests.rs Outdated Show resolved Hide resolved
clangenb
clangenb approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix. LGTM!

@clangenb clangenb merged commit 0a1df1b into master Aug 24, 2023
6 checks passed
@clangenb clangenb deleted the assignment-bug branch August 24, 2023 11:59
@clangenb clangenb mentioned this pull request Aug 24, 2023
Closed
@brenzi brenzi mentioned this pull request Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cycle 48 shows more assigned users than have registered
2 participants
@pifragile @clangenb