Add a PUT handler for the local bucket server. #1635
+97
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All committers have signed the CLA. |
eandre
reviewed
Dec 6, 2024
| @@ -1,12 +1,17 @@ | |||
| package objects | |||
|
|
|||
There was a problem hiding this comment.
This package implements essentially the “public CDN” for buckets. Do we want to serve the signed uploads/downloads from there, too? I would have thought it’s something implemented by the API server. Our local corresponding thing would be the gcsemu package.
There was a problem hiding this comment.
No you are right, the API server is probably a better fit. I'll try that approach and update or close this PR. Thanks.
erikcarlsson
force-pushed
the
main
branch
2 times, most recently
from
5652749 to
5daf8f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.