Add support for prometheus/pushgateway:>=0.10 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add allowance of status 200 for prometheus/pushgateway >=0.10.0 (https://github.com/prometheus/pushgateway/releases/tag/v0.10.0)
piotrooo
reviewed
Nov 11, 2019
martinssipenko
added a commit
to martinssipenko/prometheus_client_php
that referenced
this pull request
Nov 19, 2019
* master: Add support for prometheus/pushgateway:>=0.10 (endclothing#17) Introduce Continuous Integration (endclothing#20)
martinssipenko
added a commit
to martinssipenko/prometheus_client_php
that referenced
this pull request
Nov 29, 2019
* master: Add support for prometheus/pushgateway:>=0.10 (endclothing#17) Introduce Continuous Integration (endclothing#20)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prometheus/pushgateway release 0.10. changed the response status code when pushing metrics from 202 to 200 (see: https://github.com/prometheus/pushgateway/releases/tag/v0.10.0).
This fix it and let it downwards compatible for older pushgateway releases.
I've also added some tests and added the guzzlehttp/client per injection for easier testing.
Additionally I've fixed an issue with wrong type declerations of groupingKeys.
Closes #15
Closes #16