common: Don’t commit arbitrary files into the ostree-metadata branch #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the ostree-metadata branch (which only happens when configured with --enable-p2p), we are supposed to create empty commits which contain only metadata. However, the code to do this was wrong, and was instead pulling in all the files from the current working directory and committing them. Fix that code to actually create an empty commit. This could have been a fairly serious bug were it not for the fact that nobody’s using this code because it’s all experimental. Spotted as part of ostreedev/ostree#1158. Signed-off-by: Philip Withnall <withnall@endlessm.com> Closes: #1066 Approved by: alexlarsson
mwleeds
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the ostree-metadata branch (which only happens when
configured with --enable-p2p), we are supposed to create empty commits
which contain only metadata. However, the code to do this was wrong, and
was instead pulling in all the files from the current working directory
and committing them.
Fix that code to actually create an empty commit.
This could have been a fairly serious bug were it not for the fact that
nobody’s using this code because it’s all experimental.
Spotted as part of ostreedev/ostree#1158.
Signed-off-by: Philip Withnall withnall@endlessm.com
Closes: #1066
Approved by: alexlarsson
This isn’t attached to a particular task; just a recent upstream fix which I really think we ought to have.