T35541 cleanups #127
Merged
T35541 cleanups #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding a BlockCode node, select the new node as part of the undo / redo action. This is consistent with the behaviour of other actions in Godot. https://phabricator.endlessm.com/T35541
manuq
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
I was testing main today and noticed that now selecting the BlockCode node also always selects the parent / affected node. This leaves "2 nodes selected" in the inspector. I can understand the rationale behind it, but I also found it a bit controversial and different to what other plugins do. In any case, this PR lets me select the BlockCode node again by clicking twice on it in the Scene Tree. Allowing me to inspect the underlaying block script data resource in the Inspector again for debugging. So +1 from my side with this cleanup. All changes look fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.endlessm.com/T35541