Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always scroll block canvas to the top-left block on open #128

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

dylanmccall
Copy link
Contributor

No description provided.

@dylanmccall dylanmccall force-pushed the block-canvas-initial-position branch from 25e14ab to 5fa9380 Compare July 10, 2024 22:43
For this to work correctly, we need to change WindowContainer to be a
Control, instead of a MarginContainer. The MarginContainer node was
occasionally changing the Window node's position on its own.
@dylanmccall dylanmccall force-pushed the block-canvas-initial-position branch from 5fa9380 to 96691a9 Compare July 10, 2024 22:55
@dylanmccall dylanmccall changed the title WIP: Always scroll block canvas to the top-left block on open Always scroll block canvas to the top-left block on open Jul 10, 2024
@dylanmccall dylanmccall marked this pull request as ready for review July 10, 2024 22:55
Copy link
Contributor

@manuq manuq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@manuq manuq merged commit 5d57c2e into main Jul 10, 2024
2 checks passed
@manuq manuq deleted the block-canvas-initial-position branch July 10, 2024 22:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants