Parameter input: change text modification logic #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbnicholson
requested changes
Jul 17, 2024
| @@ -126,10 +131,16 @@ func get_string() -> String: | |||
| return "%s" % input | |||
|
|
|||
|
|
|||
| func _on_line_edit_text_changed(new_text): | |||
| func _on_line_edit_text_submitted(new_text): | |||
There was a problem hiding this comment.
This function is also used to handle the Vector2 input signals. You'll need to split those to a separate function (arguably they should have been already).
There was a problem hiding this comment.
Oh I totally missed that, good catch! PR updated. It is a bit boilerplate now. An alternative would be to connect to the callbacks in code (not in the Signals dock in the editor) and bind the corresponding LineEdit as argument. And also have a dict for the last text submitted, with each LineEdit as key.
manuq
force-pushed
the
improve-lineedit-input
branch
2 times, most recently
from
fa535ce
to
4500268
Compare
Previously any text change was sending the modified signal, adding too many actions to the undo/redo history (one per typed character). This was also capturing shortcuts like Ctrl-Z for undoing and sending the modified signal, thus piling to the history, not going back. Instead, send the modified signal when the line edit is submitted (enter key pressed) or when it loses focus and the text has changed. Do this for the 3 line edit nodes. https://phabricator.endlessm.com/T35566
manuq
force-pushed
the
improve-lineedit-input
branch
from
4500268
to
9f3f1a7
Compare
dylanmccall
approved these changes
Jul 17, 2024
|
@dbnicholson do you think this is good for merging now? |
dbnicholson
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously any text change was sending the modified signal, adding too many actions to the undo/redo history (one per typed character). This was also capturing shortcuts like Ctrl-Z for undoing and sending the modified signal, thus piling to the history, not going back.
Instead, send the modified signal when the line edit is submitted (enter key pressed) or when it loses focus and the text has changed.
https://phabricator.endlessm.com/T35566