Fix InstructionTree and Block circular dependency #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 4338632 there's been a circular dependency between InstructionTree and Block that manifests as a script error due to a non-existent resource in a seemingly unrelated object. Several components use InstructionTree.TreeNode including Block, and prior to 4338632 there were no references to any non-native classes. Split out the block tree functions to a new BlockTreeUtil class so that InstructionTree no longer contains references to Block.
|
This will almost certainly cause conflicts in the decoupling PRs. |
dbnicholson
commented
Aug 1, 2024
| @@ -3,6 +3,7 @@ extends Control | |||
|
|
|||
| const Background = preload("res://addons/block_code/ui/blocks/utilities/background/background.gd") | |||
| const BlockCanvas = preload("res://addons/block_code/ui/block_canvas/block_canvas.gd") | |||
| const BlockTreeUtil = preload("res://addons/block_code/ui/block_tree_util.gd") | |||
There was a problem hiding this comment.
I'm not at all convinced of this name or path. What seemed to be in common in the functions moved was that they were about a tree of Block nodes. @wnbaum's work completely changes the way this is handled.
There was a problem hiding this comment.
If this is going to be changed anyways maybe the current name/path doesn't matter that much?
No problem, we can rebase. |
manuq
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 4338632 there's been a circular dependency between InstructionTree and Block that manifests as a script error due to a non-existent resource in a seemingly unrelated object. Several components use InstructionTree.TreeNode including Block, and prior to 4338632 there were no references to any non-native classes. Split out the block tree functions to a new BlockTreeUtil class so that InstructionTree no longer contains references to Block.